lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues
    Hi Jiada,

    Thanks for your patches.

    On 2019-04-24 14:11:43 +0900, Jiada Wang wrote:
    > There are issues with interrupt handling in rcar_gen3_thermal driver.
    >
    > Currently IRQ is remain enabled after .remove, later if device is probed,
    > IRQ is requested before .thermal_init, this may cause IRQ function be
    > triggered but not able to clear IRQ status, thus cause system to hang.
    >
    > Since the irq line isn't shared between different devices,
    > so the proper interrupt type flag should be IRQF_ONESHOT.
    >
    > This patch-set fix these interrupt handling retated issues.

    I really like this series, nice work.

    Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

    >
    > ---
    > v4: remove 'spinlock_t lock'
    > add Fixes tag in ("thermal: rcar_gen3_thermal: fix interrupt type")
    > fix typos in ("thermal: rcar_gen3_thermal: disable interrupt in .remove")
    >
    > v3: fix to use correct code base
    > remove unused "flag" variable in rcar_gen3_thermal_irq
    >
    > v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED
    > disable interrupt in .remove
    >
    > v1: initial version
    >
    > Jiada Wang (2):
    > thermal: rcar_gen3_thermal: fix interrupt type
    > thermal: rcar_gen3_thermal: disable interrupt in .remove
    >
    > drivers/thermal/rcar_gen3_thermal.c | 41 +++++++----------------------
    > 1 file changed, 9 insertions(+), 32 deletions(-)
    >
    > --
    > 2.19.2
    >

    --
    Regards,
    Niklas Söderlund

    \
     
     \ /
      Last update: 2019-05-08 01:55    [W:4.997 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site