lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v7 0/13] Exynos5 Dynamic Memory Controller driver
Date
Hi all,

This is v7 of the patch set which adds support of Dynamic Memory Controller
for Exynos5422 SoC.
The driver supports Dynamic Voltage and Frequency Scalling
for the DMC and DRAM. It also provides needed timings for different
speed operations of the DRAM memory.
There is also new generic code in of_memory and headers which allows to parse
LPDDR3 memories defined in device-tree.

The patch set depends on changes to Exynos PPMU v3 [1] or newer:
'Exynos Performance Monitoring Counters enhancements'

changes:
v7:
- added using regmap in chipid registers and clock registers
- in DT added "syscon" to compatible field in clock and chipid
- added two addition clocks in clocks definition file which were there
in first implementation but now are grouped and commented properly
(CLK_DOUT_PCLK_DREX0, CLK_DOUT_PCLK_DREX1)
- the BPLL ratio table now is set for Exynos 5422 and 5800 and not for 5420
- in DMC driver, changed code macro which generates functions for setup events
into normal three functions as Krzysztof suggested
- moved 'clock_prepare_enable()' calls into the same function where 'disable'
were called
- changed 'timing_reg' static variables into static const
- in DMC driver: the proper device_node *np_ddr is now put correctly
- in DMC driver: removed code related to counters_enabled
- mapped only 0x100 from DREX registers
- in DT memory node there is now 'reg' as Rob suggested instead of 'max-freq'
- in Documentation/devicetree/bindings/lpddr2 renamed into 'ddr' and the lpdd3*
files landed there.
- cleaned the commit subject and message as Rob suggested for the patch 4/10 in v6
- added doxygen comments to exported functions in of_memory file
- cleaned minor issues like: missing space, 2 empty lines, in the doc JESD209-2 ->
JESD209-3C, removed 'status = "okay"' from the doc file, etc
- based on v5.1 (+ PPMU patches from [1])
v6:
- driver code has been converted to use generic code which parses DT memory
definition in drivers/memory/of_memory.c
- extended of_memory by LPDDR3 support (there was LPDDR2 made by TI)
- extended jedec_lpddr.h by the needed structures for LPDDR3 (AC timings)
- driver file moved to proper directory, where other memory controllers
live, which is in this case drivers/memory/samsung/
- driver code now uses regmap_{read|write} to access registers for pausing
and changing timings set, as suggested by Chanwoo
- DT contains simple definition of memory device, similar to LPDDR2 made by TI
- driver code generates the needed timings for registered OPPs, based on
memory description in DT
- patch 1 contains Rob's ACK,
- simplified memory bandwidth calculation
- added debug information files with timings, raw counters and statistics
- updated dt-bindings files accordingly
- based on v5.1-rc5 (+ PPMU patches from [1])
v5:
- removed unneeded wrapper functions i.e. for regulator_set_voltage
- removed unused defines
- removed direct access to clock register base and used CCF for
pause and timing set usage
- switched to OPP comming from DT according to Chanowoo's comments
- switched to timings comming from DT, added parsing function
- extended dt-binding with description of OPPs and timings
- according to Rob Herring comment, moved dt-binding file before driver code
in the patch set.
- rebased on top of v5.0
v4:
- removed unneeded DPLL and G3D clocks IDs
- changed names of parent clocks for mout_mx_mspll_ccore_phy_p
and added one more parent: mout_sclk_epll
- removed 933Mhz and 138MHz from the BPLL ratio table
v3:
- in DTS align to proper indent the clocks and clock-names entries
v2:
- changed file name exynos5-dmc.c -> exynos5422-dmc.c
and related entries in other files
- changed dt-binding file name
- changed config entry to CONFIG_ARM_EXYNOS5422_DMC_DEVFREQ
- removed sysfs and print info messages (print only one line)
- removed function exynos5_read_chip_info and compact code
- changed dt-binding patch and move it up in the patch set
- new entries in MAINTAINERS are added with the driver c code
- clean-up in DTS file: renamed nodes to 'ppmu' and 'memory-controller',
entries moved to suggested location (before nocp nodes or after),
moved according to alfabetical order, compacted clocks names with right indent.

Regards,
Lukasz Luba

[1] https://lkml.org/lkml/2019/4/19/158

Lukasz Luba (13):
clk: samsung: add needed IDs for DMC clocks in Exynos5420
clk: samsung: add new clocks for DMC for Exynos5422 SoC
clk: samsung: add BPLL rate table for Exynos 5422 SoC
dt-bindings: ddr: rename lpddr2 directory
dt-bindings: ddr: add LPDDR3 memories
drivers: memory: extend of_memory by LPDDR3 support
dt-bindings: memory-controllers: add Exynos5422 DMC device description
drivers: memory: add DMC driver for Exynos5422
drivers: devfreq: events: add Exynos PPMU new events
ARM: dts: exynos: add chipid label and syscon compatible
ARM: dts: exynos: add syscon to clock compatible
ARM: dts: exynos: add DMC device for exynos5422
ARM: exynos_defconfig: enable DMC driver

.../devicetree/bindings/ddr/lpddr2-timings.txt | 52 +
Documentation/devicetree/bindings/ddr/lpddr2.txt | 102 ++
.../devicetree/bindings/ddr/lpddr3-timings.txt | 58 +
Documentation/devicetree/bindings/ddr/lpddr3.txt | 97 ++
.../devicetree/bindings/lpddr2/lpddr2-timings.txt | 52 -
.../devicetree/bindings/lpddr2/lpddr2.txt | 102 --
.../bindings/memory-controllers/exynos5422-dmc.txt | 74 +
MAINTAINERS | 8 +
arch/arm/boot/dts/exynos5.dtsi | 4 +-
arch/arm/boot/dts/exynos5420.dtsi | 121 ++
arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 122 ++
arch/arm/boot/dts/exynos5800.dtsi | 2 +-
arch/arm/configs/exynos_defconfig | 1 +
drivers/clk/samsung/clk-exynos5420.c | 75 +-
drivers/devfreq/event/exynos-ppmu.c | 6 +
drivers/memory/of_memory.c | 148 ++
drivers/memory/of_memory.h | 20 +-
drivers/memory/samsung/Kconfig | 17 +
drivers/memory/samsung/Makefile | 1 +
drivers/memory/samsung/exynos5422-dmc.c | 1761 ++++++++++++++++++++
include/dt-bindings/clock/exynos5420.h | 28 +-
include/memory/jedec_ddr.h | 62 +
22 files changed, 2744 insertions(+), 169 deletions(-)
create mode 100644 Documentation/devicetree/bindings/ddr/lpddr2-timings.txt
create mode 100644 Documentation/devicetree/bindings/ddr/lpddr2.txt
create mode 100644 Documentation/devicetree/bindings/ddr/lpddr3-timings.txt
create mode 100644 Documentation/devicetree/bindings/ddr/lpddr3.txt
delete mode 100644 Documentation/devicetree/bindings/lpddr2/lpddr2-timings.txt
delete mode 100644 Documentation/devicetree/bindings/lpddr2/lpddr2.txt
create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
create mode 100644 drivers/memory/samsung/exynos5422-dmc.c

--
2.7.4

\
 
 \ /
  Last update: 2019-05-06 17:14    [W:0.245 / U:2.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site