lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 042/122] i40e: fix WoL support check
    Date
    [ Upstream commit f669d24f3dd00beab452c0fc9257f6a942ffca9b ]

    The current check for WoL on i40e is broken. Code comment says only
    magic packet is supported, so only check for that.

    Fixes: 540a152da762 (i40e/ixgbe/igb: fail on new WoL flag setting WAKE_MAGICSECURE)

    Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
    index a6bc7847346b..5d544e661445 100644
    --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
    +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
    @@ -2378,8 +2378,7 @@ static int i40e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
    return -EOPNOTSUPP;

    /* only magic packet is supported */
    - if (wol->wolopts && (wol->wolopts != WAKE_MAGIC)
    - | (wol->wolopts != WAKE_FILTER))
    + if (wol->wolopts & ~WAKE_MAGIC)
    return -EOPNOTSUPP;

    /* is this a new value? */
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-06 16:37    [W:5.887 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site