Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/mm: fix section mismatch for setup_kup() | Date | Mon, 6 May 2019 23:54:09 +1000 (AEST) |
| |
On Mon, 2019-05-06 at 08:10:43 UTC, Christophe Leroy wrote: > commit b28c97505eb1 ("powerpc/64: Setup KUP on secondary CPUs") > moved setup_kup() out of the __init section. As stated in that commit, > "this is only for 64-bit". But this function is also used on PPC32, > where the two functions called by setup_kup() are in the __init > section, so setup_kup() has to either be kept in the __init > section on PPC32 or marked __ref. > > This patch marks it __ref, it fixes the below build warnings. > > MODPOST vmlinux.o > WARNING: vmlinux.o(.text+0x169ec): Section mismatch in reference from the function setup_kup() to the function .init.text:setup_kuep() > The function setup_kup() references > the function __init setup_kuep(). > This is often because setup_kup lacks a __init > annotation or the annotation of setup_kuep is wrong. > > WARNING: vmlinux.o(.text+0x16a04): Section mismatch in reference from the function setup_kup() to the function .init.text:setup_kuap() > The function setup_kup() references > the function __init setup_kuap(). > This is often because setup_kup lacks a __init > annotation or the annotation of setup_kuap is wrong. > > Fixes: b28c97505eb1 ("powerpc/64: Setup KUP on secondary CPUs") > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/67d53f30e23ec66aa7bbdd1592d5e64d
cheers
| |