Messages in this thread Patch in this message | | | From | Suwan Kim <> | Subject | [PATCH 1/2] usbip: Remove repeated setting of hcd->state in vhci_bus_suspend() | Date | Mon, 6 May 2019 21:55:49 +0900 |
| |
When hcd suspends execution, hcd_bus_suspend() calls vhci_bus_suspend() which sets hcd->state as HC_STATE_SUSPENDED. But after calling vhci_bus_suspend(), hcd_bus_suspend() also sets hcd->state as HC_STATE_SUSPENDED. So, setting hcd->state in vhci_hcd_suspend() is unnecessary.
Signed-off-by: Suwan Kim <suwan.kim027@gmail.com> --- drivers/usb/usbip/vhci_hcd.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 667d9c0ec905..e6f378d00fb6 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -1238,10 +1238,6 @@ static int vhci_bus_suspend(struct usb_hcd *hcd) dev_dbg(&hcd->self.root_hub->dev, "%s\n", __func__); - spin_lock_irqsave(&vhci->lock, flags); - hcd->state = HC_STATE_SUSPENDED; - spin_unlock_irqrestore(&vhci->lock, flags); - return 0; } -- 2.20.1
| |