Messages in this thread | | | Subject | Re: [v5 2/3] mm/hotplug: make remove_memory() interface useable | From | Dave Hansen <> | Date | Mon, 6 May 2019 11:04:01 -0700 |
| |
On 5/6/19 11:01 AM, Dan Williams wrote: >>> +void __remove_memory(int nid, u64 start, u64 size) >>> { >>> + >>> + /* >>> + * trigger BUG() is some memory is not offlined prior to calling this >>> + * function >>> + */ >>> + if (try_remove_memory(nid, start, size)) >>> + BUG(); >>> +} >> Could we call this remove_offline_memory()? That way, it makes _some_ >> sense why we would BUG() if the memory isn't offline. > Please WARN() instead of BUG() because failing to remove memory should > not be system fatal.
That is my preference as well. But, the existing code BUG()s, so I'm OK-ish with this staying for the moment until we have a better handle on what all the callers do if this fails.
| |