[lkml]   [2019]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 0/3] MIPS: ath79: add ag71xx support

Am 04.05.19 um 18:01 schrieb Chuanhong Guo:
> Hi!
> On Mon, Apr 22, 2019 at 2:41 PM Oleksij Rempel <> wrote:
>> [...]
>> - most of deficetree bindings was removed. Not every thing made sense
>> and most of it is SoC specific, so it is possible to detect it by
>> compatible.
> I noticed that you've dropped all PLL and gmac-config stuff. These are
> board-specific properties and PLL registers should be changed
> accroding to negotiated ethernet speed. By dropping them, you rely on
> bootloader to configure everything corectly for you (which has been
> proven unreliable for many ath79 routers) and ethernet won't work if
> negotiated speed changed after u-boot's configuration.
Both of them should be properly implemented before mainlining. This is
the reason why they removed.


 \ /
  Last update: 2019-05-04 19:47    [W:0.078 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site