lkml.org 
[lkml]   [2019]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 03/17] soc: qcom: ipa: main code
From
Date
On 5/31/19 4:50 PM, David Miller wrote:
> From: Alex Elder <elder@linaro.org>
> Date: Thu, 30 May 2019 22:53:34 -0500
>
>> + void *route_virt;
> ...
>> + void *filter_virt;
> ...
>
> If these are arrays of u64's, please declare them as "u64 *" instead of
> the opaque "void *".

Good idea. I hadn't paid attention to that. These tables are
arrays of 64-bit addresses so it's better to represent them that
way.

Thanks.

-Alex

\
 
 \ /
  Last update: 2019-06-01 00:27    [W:0.074 / U:32.800 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site