Messages in this thread | | | Subject | Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects | From | Dmitry Osipenko <> | Date | Fri, 31 May 2019 15:45:06 +0300 |
| |
31.05.2019 12:04, Bitan Biswas пишет: > > > On 5/30/19 4:43 AM, Dmitry Osipenko wrote: >> 30.05.2019 14:36, Dmitry Osipenko пишет: >>> 30.05.2019 9:14, Bitan Biswas пишет: >>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >>>> except for BUG/BUG_ON checks >>> >>> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire, >>> hence there is absolutely no good reason in making system unusable on a >>> software bug. BUG_ON may be more useful for development, but not for a >>> casual daily usage. > I shall update the patch to remove the BUG/BUG_ON calls.
Please replace them with WARN_ON_ONCE.
| |