Messages in this thread Patch in this message | | | From | Petr Mladek <> | Subject | [PATCH 2/3] livepatch: Remove duplicate warning about missing reliable stacktrace support | Date | Fri, 31 May 2019 09:41:46 +0200 |
| |
WARN_ON_ONCE() could not be called safely under rq lock because of console deadlock issues.
It can be simply removed. A better descriptive message is written in klp_enable_patch() when klp_have_reliable_stack() fails. The remaining debug message is good enough.
Signed-off-by: Petr Mladek <pmladek@suse.com> --- kernel/livepatch/transition.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c index abb2a4a2cbb2..1bf362df76e1 100644 --- a/kernel/livepatch/transition.c +++ b/kernel/livepatch/transition.c @@ -247,7 +247,6 @@ static int klp_check_stack(struct task_struct *task, char *err_buf) int ret, nr_entries; ret = stack_trace_save_tsk_reliable(task, entries, ARRAY_SIZE(entries)); - WARN_ON_ONCE(ret == -ENOSYS); if (ret < 0) { snprintf(err_buf, STACK_ERR_BUF_SIZE, "%s: %s:%d has an unreliable stack\n", -- 2.16.4
| |