Messages in this thread | | | From | Daniel Baluta <> | Subject | Re: [PATCH 0/3] Add mclk0 clock source for SAI | Date | Thu, 30 May 2019 08:32:41 +0000 |
| |
On Wed, 2019-05-29 at 16:03 -0700, Nicolin Chen wrote: > On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote: > > > 1) SAI clock source select MUX is really part of the hardware > > 2) flexibility! We let DT tell us which is the option for MUX > > option 0. > > I think the "MUX" is plausible comparing to your previous version. > As long as DT maintainers ack the DT binding doc, I would be okay > to ack too. Just one comments at the dts/dtsi changes, I know the > driver would just warn old DTs, but it does change the behavior at > the mclk_clk[0] from previously bus_clk to NULL after this series.
Thanks for review, will fix in v2.
| |