lkml.org 
[lkml]   [2019]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.1 333/405] drm/amd/display: Reset alpha state for planes to the correct values
    Date
    [ Upstream commit eec3d5efd16d13984a88396b685ae17462fb6d87 ]

    [Why]
    The plane_reset callback is subclassed but hasn't been updated since
    the drm helper got updated to include resetting alpha related state
    (state->alpha and state->pixel_blend_mode). The overlay planes
    exposed by amdgpu_dm were therefore being rendered as invisible by
    default ever since supported was exposed for alpha blending properties
    on overlays.

    This caused regressions in igt@kms_plane_multiple@atomic-tiling-none
    and igt@kms_plane@plane-position-covered-pipe tests.

    [How]
    Reset the plane state values to their correct values as defined in
    the drm helper.

    This fixes the IGT test regression.

    Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
    Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index c212bff457eec..b14369ab151f6 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -3587,6 +3587,8 @@ static void dm_drm_plane_reset(struct drm_plane *plane)
    plane->state = &amdgpu_state->base;
    plane->state->plane = plane;
    plane->state->rotation = DRM_MODE_ROTATE_0;
    + plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
    + plane->state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
    }
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 06:42    [W:4.337 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site