lkml.org 
[lkml]   [2019]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 214/276] ASoC: eukrea-tlv320: fix a leaked reference by adding missing of_node_put
    Date
    [ Upstream commit b820d52e7eed7b30b2dfef5f4213a2bc3cbea6f3 ]

    The call to of_parse_phandle returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo nding object release within this function.
    ./sound/soc/fsl/eukrea-tlv320.c:127:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 102, but without a correspo nding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Liam Girdwood <lgirdwood@gmail.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Jaroslav Kysela <perex@perex.cz>
    Cc: Takashi Iwai <tiwai@suse.com>
    Cc: alsa-devel@alsa-project.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/fsl/eukrea-tlv320.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/fsl/eukrea-tlv320.c b/sound/soc/fsl/eukrea-tlv320.c
    index 191426a6d9adf..30a3d68b5c033 100644
    --- a/sound/soc/fsl/eukrea-tlv320.c
    +++ b/sound/soc/fsl/eukrea-tlv320.c
    @@ -118,13 +118,13 @@ static int eukrea_tlv320_probe(struct platform_device *pdev)
    if (ret) {
    dev_err(&pdev->dev,
    "fsl,mux-int-port node missing or invalid.\n");
    - return ret;
    + goto err;
    }
    ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port);
    if (ret) {
    dev_err(&pdev->dev,
    "fsl,mux-ext-port node missing or invalid.\n");
    - return ret;
    + goto err;
    }

    /*
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 06:05    [W:4.018 / U:1.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site