lkml.org 
[lkml]   [2019]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 083/346] scsi: qla2xxx: Fix abort handling in tcm_qla2xxx_write_pending()
    Date
    [ Upstream commit e209783d66bca04b5fce4429e59338517ffc1a0b ]

    Implementations of the .write_pending() callback functions must guarantee
    that an appropriate LIO core callback function will be called immediately or
    at a later time. Make sure that this guarantee is met for aborted SCSI
    commands.

    [mkp: typo]

    Cc: Himanshu Madhani <hmadhani@marvell.com>
    Cc: Giridhar Malavali <gmalavali@marvell.com>
    Fixes: 694833ee00c4 ("scsi: tcm_qla2xxx: Do not allow aborted cmd to advance.") # v4.13.
    Fixes: a07100e00ac4 ("qla2xxx: Fix TMR ABORT interaction issue between qla2xxx and TCM") # v4.5.
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Acked-by: Himanshu Madhani <hmadhani@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    index 283e6b80abb5a..708151b72ee9f 100644
    --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
    @@ -399,6 +399,8 @@ static int tcm_qla2xxx_write_pending(struct se_cmd *se_cmd)
    cmd->se_cmd.transport_state,
    cmd->se_cmd.t_state,
    cmd->se_cmd.se_cmd_flags);
    + transport_generic_request_failure(&cmd->se_cmd,
    + TCM_CHECK_CONDITION_ABORT_CMD);
    return 0;
    }
    cmd->trc_flags |= TRC_XFR_RDY;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 06:34    [W:3.132 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site