lkml.org 
[lkml]   [2019]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 199/346] x86/microcode: Fix the ancient deprecated microcode loading method
    Date
    [ Upstream commit 24613a04ad1c0588c10f4b5403ca60a73d164051 ]

    Commit

    2613f36ed965 ("x86/microcode: Attempt late loading only when new microcode is present")

    added the new define UCODE_NEW to denote that an update should happen
    only when newer microcode (than installed on the system) has been found.

    But it missed adjusting that for the old /dev/cpu/microcode loading
    interface. Fix it.

    Fixes: 2613f36ed965 ("x86/microcode: Attempt late loading only when new microcode is present")
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Jann Horn <jannh@google.com>
    Link: https://lkml.kernel.org/r/20190405133010.24249-3-bp@alien8.de
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/kernel/cpu/microcode/core.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
    index 97f9ada9cedaf..fc70d39b804f0 100644
    --- a/arch/x86/kernel/cpu/microcode/core.c
    +++ b/arch/x86/kernel/cpu/microcode/core.c
    @@ -418,8 +418,9 @@ static int do_microcode_update(const void __user *buf, size_t size)
    if (ustate == UCODE_ERROR) {
    error = -1;
    break;
    - } else if (ustate == UCODE_OK)
    + } else if (ustate == UCODE_NEW) {
    apply_microcode_on_target(cpu);
    + }
    }

    return error;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 06:26    [W:4.139 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site