Messages in this thread | | | Subject | Re: [PATCH] staging: media: davinci_vpfe: Remove variable vpfe_dev | From | Nishka Dasgupta <> | Date | Fri, 31 May 2019 02:39:23 +0530 |
| |
On 31/05/19 2:25 AM, Greg KH wrote: > On Fri, May 31, 2019 at 02:17:18AM +0530, Nishka Dasgupta wrote: >> Remove variable vpfe_dev and replace it with its value (since the >> function otherwise uses values directly instead of local variables). > > This says _what_ you do. But we can see that in the patch itself. > > You need to say _why_ you are doing this. > > There's no need for this change at all. Again, as I have said before, > we write code for developers to read first, the compiler second. By > making these types of changes you are making it harder to > read/understand by a developer, and providing absolutely no benifit to > the compiler at all. > > So it's actually making the code worse! > > not good at all. > > Please reconsider this type of change, as I keep asking you to.
Okay. In this case I thought it wouldn't make it worse since the function is low on local variables anyway? Clearly I was wrong, so I won't count this case as an exception in future.
Thanking you, Nishka
> greg k-h >
| |