Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH 1/2] scripts/gdb: Cleanup error handling in list helpers | Date | Fri, 03 May 2019 09:33:21 -0700 |
| |
Quoting Leonard Crestez (2019-05-03 04:19:31) > An incorrect argument to list_for_each is an internal error in gdb > scripts so a TypeError should be raised. The gdb.GdbError exception type > is intended for user errors such as incorrect invocation. > > Drop the type assertion in list_for_each_entry because list_for_each isn't > going to suddenly yield something else. > > Applies to both list and hlist
This should be done to other "type errors" in the gdb scripts too.
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > ---
Either way,
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
| |