Messages in this thread | | | Date | Fri, 3 May 2019 15:00:34 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 4/5] ASoC: mediatek: mt8516: Add ADDA DAI driver |
| |
On Thu, May 02, 2019 at 02:10:40PM +0200, Fabien Parent wrote:
> +static int mt8516_afe_adda_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai) > +{ > + struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > + unsigned int width_val = params_width(params) > 16 ? > + (AFE_CONN_24BIT_O03 | AFE_CONN_24BIT_O04) : 0;
Please write normal conditional statements rather than burying things in the variable declarations usin the ternery operator, it makes things much more legible. [unhandled content-type:application/pgp-signature] | |