Messages in this thread | | | From | Brendan Higgins <> | Date | Thu, 2 May 2019 22:48:16 -0700 | Subject | Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger |
| |
On Thu, May 2, 2019 at 6:50 PM shuah <shuah@kernel.org> wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote:
< snip >
> > diff --git a/kunit/kunit-stream.c b/kunit/kunit-stream.c > > new file mode 100644 > > index 0000000000000..93c14eec03844 > > --- /dev/null > > +++ b/kunit/kunit-stream.c > > @@ -0,0 +1,149 @@
< snip >
> > +static int kunit_stream_init(struct kunit_resource *res, void *context) > > +{ > > + struct kunit *test = context; > > + struct kunit_stream *stream; > > + > > + stream = kzalloc(sizeof(*stream), GFP_KERNEL); > > + if (!stream) > > + return -ENOMEM; > > + res->allocation = stream; > > + stream->test = test; > > + spin_lock_init(&stream->lock); > > + stream->internal_stream = new_string_stream(); > > + > > + if (!stream->internal_stream) > > + return -ENOMEM; > > What happens to stream? Don't you want to free that?
Good catch. Will fix in next revision.
< snip >
Cheers
| |