lkml.org 
[lkml]   [2019]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 09/72] net: ieee802154: fix a potential NULL pointer dereference
    On Thu 2019-05-02 17:20:31, Greg Kroah-Hartman wrote:
    > [ Upstream commit 2795e8c251614ac0784c9d41008551109f665716 ]
    >
    > In case alloc_ordered_workqueue fails, the fix releases
    > sources and returns -ENOMEM to avoid NULL pointer dereference.
    >
    > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    > Acked-by: Michael Hennerich <michael.hennerich@analog.com>
    > Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    > Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>

    > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
    > index cd1d8faccca5..cd6b95e673a5 100644
    > --- a/drivers/net/ieee802154/adf7242.c
    > +++ b/drivers/net/ieee802154/adf7242.c
    > @@ -1268,6 +1268,10 @@ static int adf7242_probe(struct spi_device *spi)
    > INIT_DELAYED_WORK(&lp->work, adf7242_rx_cal_work);
    > lp->wqueue = alloc_ordered_workqueue(dev_name(&spi->dev),
    > WQ_MEM_RECLAIM);
    > + if (unlikely(!lp->wqueue)) {
    > + ret = -ENOMEM;
    > + goto err_hw_init;
    > + }
    >

    This does ieee802154_free_hw(lp->hw) before adf7242_hw_init(). I don't
    think that's correct.
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-05-03 10:32    [W:4.339 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site