lkml.org 
[lkml]   [2019]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 24/24] osst: add a SPDX tag to osst.c
From
Date
On 5/2/19 9:55 PM, Willem Riede wrote:
> On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke <hare@suse.de
> <mailto:hare@suse.de>> wrote:
>
> On 5/2/19 2:53 PM, Christoph Hellwig wrote:
> > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
> >> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
> >>> osst.c is the only osst file missing licensing information.  Add a
> >>> GPLv2 tag for the default kernel license.
> >>>
> >>> Signed-off-by: Chriosstoph Hellwig <hch@losst.de
> <mailto:hch@losst.de>>
> >
> > FYI, my s/st/osst/ on the commit message message up my signoff, this
> > should be:
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de <mailto:hch@lst.de>>
> >
> Maybe it's time to kill osst.c for good ...
>
>
> Yes. I've been thinking about doing just that. The devices it supports
> are now thoroughly obsolete. The manufacturer has gone out of business.
> All my test drives have broken down over time, so I can't even test any
> changes any more.
>
Just when I thought to reach out to you :-)

Thing is, we've done numerous changes to the 'st' driver in the course
of the years, most of which seem to have avoided osst :-(

So what's your suggestion here?
Just drop it completely?
Or can we somehow fold the OnStream-specific things back into st.c?

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2019-05-03 10:05    [W:0.062 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site