Messages in this thread | | | From | Brendan Higgins <> | Date | Thu, 2 May 2019 22:18:22 -0700 | Subject | Re: [PATCH v2 07/17] kunit: test: add initial tests |
| |
On Thu, May 2, 2019 at 6:27 PM shuah <shuah@kernel.org> wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here.
Sounds reasonable. Will fix in the next revision.
< snip >
Thanks!
| |