Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings | Date | Wed, 29 May 2019 22:34:44 +0100 |
| |
James Morris <jmorris@namei.org> wrote:
> > + > > + if (flags & ~KEYCTL_MOVE_EXCL) > > + return -EINVAL; > > + > > + key_ref = lookup_user_key(id, KEY_LOOKUP_CREATE, KEY_NEED_LINK); > > + if (IS_ERR(key_ref)) { > > + ret = PTR_ERR(key_ref); > > + goto error; > > + } > > This could probably be a simple return, as there is no cleanup.
Changed.
David
| |