lkml.org 
[lkml]   [2019]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 6/7] keys: Add a keyctl to move a key between keyrings
Date
James Morris <jmorris@namei.org> wrote:

> > +
> > + if (flags & ~KEYCTL_MOVE_EXCL)
> > + return -EINVAL;
> > +
> > + key_ref = lookup_user_key(id, KEY_LOOKUP_CREATE, KEY_NEED_LINK);
> > + if (IS_ERR(key_ref)) {
> > + ret = PTR_ERR(key_ref);
> > + goto error;
> > + }
>
> This could probably be a simple return, as there is no cleanup.

Changed.

David

\
 
 \ /
  Last update: 2019-05-29 23:35    [W:1.205 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site