lkml.org 
[lkml]   [2019]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper
Date
Hi Christoph,

On 5/29/19 8:21 AM, Christoph Hellwig wrote:
>> +/* is_downstream_to_pci_bridge - test if a device belongs to the
>> + * PCI sub-hierarchy of a candidate PCI-PCI bridge
>> + *
>> + * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy
>> + * @bridge: the candidate PCI-PCI bridge
>> + *
>> + * Return: true if @dev belongs to @bridge PCI sub-hierarchy
>> + */
>
> This is not valid kerneldoc comment. Try something like this:
>
> /**
> * is_downstream_to_pci_bridge - test if a device belongs to the PCI
> * sub-hierarchy of a candidate PCI-PCI bridge
> * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy
> * @bridge: the candidate PCI-PCI bridge
> *
> * Returns true if @dev belongs to @bridge PCI sub-hierarchy, else false.
> */
>
Sure,

just replaced Returns by Return:

Thanks

Eric

\
 
 \ /
  Last update: 2019-05-29 17:43    [W:0.083 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site