Messages in this thread | | | From | Auger Eric <> | Subject | Re: [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper | Date | Wed, 29 May 2019 17:43:05 +0200 |
| |
Hi Christoph,
On 5/29/19 8:21 AM, Christoph Hellwig wrote: >> +/* is_downstream_to_pci_bridge - test if a device belongs to the >> + * PCI sub-hierarchy of a candidate PCI-PCI bridge >> + * >> + * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy >> + * @bridge: the candidate PCI-PCI bridge >> + * >> + * Return: true if @dev belongs to @bridge PCI sub-hierarchy >> + */ > > This is not valid kerneldoc comment. Try something like this: > > /** > * is_downstream_to_pci_bridge - test if a device belongs to the PCI > * sub-hierarchy of a candidate PCI-PCI bridge > * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy > * @bridge: the candidate PCI-PCI bridge > * > * Returns true if @dev belongs to @bridge PCI sub-hierarchy, else false. > */ > Sure,
just replaced Returns by Return:
Thanks
Eric
| |