lkml.org 
[lkml]   [2019]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver
From
Date

Hi Greg,

On 5/28/19 6:24 PM, Greg KH wrote:
> On Tue, May 28, 2019 at 03:20:31PM -0500, richard.gong@linux.intel.com wrote:
>> +static int rsu_send_msg(struct stratix10_rsu_priv *priv,
>> + enum stratix10_svc_command_code command,
>> + unsigned long arg,
>> + void (*callback)(struct stratix10_svc_client *client,
>> + struct stratix10_svc_cb_data *data))
>
> Odd indentation for arg, and then callback.
>
> Why isn't callback a typedef to make this simpler to use?
>

I will make correction in the next submission.

> thanks,
>
> greg k-h
>

Regards,
Richard

\
 
 \ /
  Last update: 2019-05-29 17:01    [W:0.152 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site