Messages in this thread | | | Subject | Re: [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver | From | Richard Gong <> | Date | Wed, 29 May 2019 10:12:22 -0500 |
| |
Hi Greg,
On 5/28/19 6:24 PM, Greg KH wrote: > On Tue, May 28, 2019 at 03:20:31PM -0500, richard.gong@linux.intel.com wrote: >> +static int rsu_send_msg(struct stratix10_rsu_priv *priv, >> + enum stratix10_svc_command_code command, >> + unsigned long arg, >> + void (*callback)(struct stratix10_svc_client *client, >> + struct stratix10_svc_cb_data *data)) > > Odd indentation for arg, and then callback. > > Why isn't callback a typedef to make this simpler to use? >
I will make correction in the next submission.
> thanks, > > greg k-h >
Regards, Richard
| |