lkml.org 
[lkml]   [2019]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 087/128] cpufreq: pmac32: fix possible object reference leak
    Date
    [ Upstream commit 8d10dc28a9ea6e8c02e825dab28699f3c72b02d9 ]

    The call to of_find_node_by_name returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./drivers/cpufreq/pmac32-cpufreq.c:557:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 552, but without a corresponding object release within this function.
    ./drivers/cpufreq/pmac32-cpufreq.c:569:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 552, but without a corresponding object release within this function.
    ./drivers/cpufreq/pmac32-cpufreq.c:598:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 587, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: linux-pm@vger.kernel.org
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cpufreq/pmac32-cpufreq.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c
    index ff44016ea0312..641f8021855a7 100644
    --- a/drivers/cpufreq/pmac32-cpufreq.c
    +++ b/drivers/cpufreq/pmac32-cpufreq.c
    @@ -551,6 +551,7 @@ static int pmac_cpufreq_init_7447A(struct device_node *cpunode)
    volt_gpio_np = of_find_node_by_name(NULL, "cpu-vcore-select");
    if (volt_gpio_np)
    voltage_gpio = read_gpio(volt_gpio_np);
    + of_node_put(volt_gpio_np);
    if (!voltage_gpio){
    pr_err("missing cpu-vcore-select gpio\n");
    return 1;
    @@ -587,6 +588,7 @@ static int pmac_cpufreq_init_750FX(struct device_node *cpunode)
    if (volt_gpio_np)
    voltage_gpio = read_gpio(volt_gpio_np);

    + of_node_put(volt_gpio_np);
    pvr = mfspr(SPRN_PVR);
    has_cpu_l2lve = !((pvr & 0xf00) == 0x100);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-30 05:43    [W:4.810 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site