Messages in this thread | | | Date | Tue, 28 May 2019 23:11:02 +0300 | From | Vladimir Davydov <> | Subject | Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal |
| |
On Tue, May 28, 2019 at 07:58:17PM +0000, Roman Gushchin wrote: > It looks like outstanding questions are: > 1) synchronization around the dying flag > 2) removing CONFIG_SLOB in 2/7 > 3) early sysfs_slab_remove() > 4) mem_cgroup_from_kmem in 7/7 > > Please, let me know if I missed anything.
Also, I think that it might be possible to get rid of RCU call in kmem cache destructor, because the cgroup subsystem already handles it and we could probably piggyback - see my comment to 5/7. Not sure if it's really necessary, since we already have RCU in SLUB, but worth looking into, I guess, as it might simplify the code a bit.
| |