[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject答复: 答复: [PATCH] input: alps-fix the i ssue alps cs19 trackstick do not work.
Add Kawase-san.

发件人: Pali Rohár <>
发送时间: Tuesday, May 28, 2019 3:18 PM
收件人: 劉 曉曉 Xiaoxiao Liu <>
抄送: XiaoXiao Liu <>;;;;;; 曹 曉建 Xiaojian Cao <>;; 斉藤 直樹 Naoki Saito <>
主题: Re: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

On Tuesday 28 May 2019 01:37:14 Xiaoxiao Liu wrote:
> Add Saito-san.
> Hi Hui,
> Does it mean that your device (reported to kernel) sends only trackstick packets and not touchpad?
> -> Yes.

Ok, I think this answers all questions.

So your patch is not correct as it registers "fake" touchpad device even there is no touchpad at all.

You should fix your patch to not register touchpad input device, in your case it should register only trackstick device. I suggest to add some flag which would indicate such device (e.g. ALPS_ONLY_TRACKSTICK).

Also currently kernel exports following names when device has both trackstick and touchpad: "DualPoint Stick" and "DualPoint TouchPad".
And it exports name "GlidePoint" for touchpad-only device. So to be consistent you need to also modify this code for trackstick-only device.

Pali Rohár
 \ /
  Last update: 2019-05-28 09:56    [W:0.052 / U:20.280 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site