Messages in this thread | | | Date | Mon, 27 May 2019 11:59:07 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 02/10] media: rc: sunxi: Add A31 compatible |
| |
On Mon, May 27, 2019 at 10:20:05AM +0200, Clément Péron wrote: > Hi Maxime, > > On Mon, 27 May 2019 at 09:47, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > Hi, > > > > On Mon, May 27, 2019 at 12:25:28AM +0200, Clément Péron wrote: > > > Allwiner A31 has a different memory mapping so add the compatible > > > we will need it later. > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > > --- > > > drivers/media/rc/sunxi-cir.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c > > > index 307e44714ea0..29ac33b68596 100644 > > > --- a/drivers/media/rc/sunxi-cir.c > > > +++ b/drivers/media/rc/sunxi-cir.c > > > @@ -319,6 +319,7 @@ static int sunxi_ir_remove(struct platform_device *pdev) > > > static const struct of_device_id sunxi_ir_match[] = { > > > { .compatible = "allwinner,sun4i-a10-ir", }, > > > { .compatible = "allwinner,sun5i-a13-ir", }, > > > + { .compatible = "allwinner,sun6i-a31-ir", }, > > > > We should also move from reset_get_optional to the non optional > > variant for the A31, and ignore it otherwise. > > Should this be done in this series ?
Yep, please
Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |