Messages in this thread Patch in this message | | | Date | Mon, 27 May 2019 11:54:13 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] afs: Fix logically dead code in afs_update_cell |
| |
Fix logically dead code in switch statement.
Notice that *ret* is updated with -ENOMEM before the switch statement at 395:
395 switch (ret) { 396 case -ENODATA: 397 case -EDESTADDRREQ: 398 vllist->status = DNS_LOOKUP_GOT_NOT_FOUND; 399 break; 400 case -EAGAIN: 401 case -ECONNREFUSED: 402 vllist->status = DNS_LOOKUP_GOT_TEMP_FAILURE; 403 break; 404 default: 405 vllist->status = DNS_LOOKUP_GOT_LOCAL_FAILURE; 406 break; 407 }
hence, the code in the switch (except for the default case) makes no sense and is logically dead.
Fix this by removing the *ret* assignment at 390:
390 ret = -ENOMEM;
which is apparently wrong.
Addresses-Coverity-ID: 1445439 ("Logically dead code") Fixes: d5c32c89b208 ("afs: Fix cell DNS lookup") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- fs/afs/cell.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/afs/cell.c b/fs/afs/cell.c index 9c3b07ba2222..980de60bf060 100644 --- a/fs/afs/cell.c +++ b/fs/afs/cell.c @@ -387,7 +387,6 @@ static int afs_update_cell(struct afs_cell *cell) if (ret == -ENOMEM) goto out_wake; - ret = -ENOMEM; vllist = afs_alloc_vlserver_list(0); if (!vllist) goto out_wake; -- 2.21.0
| |