[lkml]   [2019]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to CTL_ULONG

On 2019/5/24 23:00, Eric Dumazet wrote:
> On Fri, May 24, 2019 at 7:30 AM Kefeng Wang <> wrote:
>> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"),
>> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG
>> instead of CTL_INT to keep consistent.
> What about compatibility with existing applications ?
> Will there sysctl() fail if they provide 32bit variable ?
> /proc/sys/net files are text files, but sysctl() system call has been
> discouraged for more than a decade.

The sysctl() system call is deprecated, so the main purpose of this patch is to keep consistent,

but it does set wrong value(eg, set 16000000000 to ipfrag_high_thresh) when use sysctl().


 \ /
  Last update: 2019-05-25 11:03    [W:0.040 / U:5.544 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site