Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 24 May 2019 06:22:02 +0200 | Subject | Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero() |
| |
On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and > __vm_map_pages() etc.) get a pointer to an array instead of a pointer > to the first element?
Also, in __vm_map_pages(), semantically w.r.t. to the comment, shouldn't the first check test for equality too? (i.e. for vm_pgoff == num)? (even if such case fails in the second test anyway).
Cheers, Miguel
| |