Messages in this thread | | | Subject | Re: [PATCH] clocksource/arm_arch_timer: Don't trace count reader functions | From | Daniel Lezcano <> | Date | Fri, 24 May 2019 12:42:39 +0200 |
| |
On 24/05/2019 11:53, Marc Zyngier wrote: > On 24/05/2019 10:10, Julien Thierry wrote: >> With v5.2-rc1, The ftrace functions_graph tracer locks up whenever it is >> enabled on arm64. >> >> Since commit 0ea415390cd3 ("clocksource/arm_arch_timer: Use >> arch_timer_read_counter to access stable counters") a function pointer >> is consistently used to read the counter instead of potentially >> referencing an inlinable function. >> >> The graph tacers relies on accessing the timer counters to compute the > > nit: tracers > >> time spent in functions which causes the lockup when attempting to trace >> these code paths. >> >> Annontate the arm arch timer counter accessors as notrace. > > nit: Annotate > >> >> Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use >> arch_timer_read_counter to access stable counters") >> Signed-off-by: Julien Thierry <julien.thierry@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Steven Rostedt <rostedt@goodmis.org> >> ---
[ ... ]
> Well spotted, thanks Julien. > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > Daniel, can you please pick this up for the next batch of clocksource fixes?
Sure.
I will take care of fixing the comments, no need to resend.
Thanks
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |