Messages in this thread | | | From | TonyWWang-oc <> | Subject | 答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file | Date | Fri, 24 May 2019 08:28:53 +0000 |
| |
On Thu, May 23, 2019, gregkh@linuxfoundation.org wrote: >> To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN >> for system recognition. >> >> Signed-off-by: TonyWWang <TonyWWang-oc@zhaoxin.com> > >Some basic patch tips. Your From: line needs to match the signed-off-by >line, which is not true here. Also, please use your name with ' ' >characters.
Thank you, I will follow these tips.
> >> +static void init_zhaoxin_cap(struct cpuinfo_x86 *c) >> +{ >> + u32 lo, hi; >> + >> + /* Test for Extended Feature Flags presence */ >> + if (cpuid_eax(0xC0000000) >= 0xC0000001) { >> + u32 tmp = cpuid_edx(0xC0000001); > >This patch is totally corrupted, with leading spaces dropped and tabs >turned into spaces. Please read the email client documentation in the >kernel directory for how to fix your email client, or just use 'git >send-email' to send the patches out directly.
Sorry for that! I was made a mistake to send the patch with HTML format. I will set up my email client correctly.
Thanks TonyWWang-oc
| |