lkml.org 
[lkml]   [2019]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V4] hsr: fix don't prune the master node from the node_db
From
From: Andreas Oetken <andreas.oetken@siemens.com>
Date: Thu, 23 May 2019 13:57:14 +0200

> Don't prune the master node in the hsr_prune_nodes function.
> Neither time_in[HSR_PT_SLAVE_A] nor time_in[HSR_PT_SLAVE_B]
> will ever be updated by hsr_register_frame_in for the master port.
> Thus, the master node will be repeatedly pruned leading to
> repeated packet loss.
> This bug never appeared because the hsr_prune_nodes function
> was only called once. Since commit 5150b45fd355
> ("net: hsr: Fix node prune function for forget time expiry") this issue
> is fixed unveiling the issue described above.
>
> Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
> Tested-by: Murali Karicheri <m-karicheri2@ti.com>

Applied.

\
 
 \ /
  Last update: 2019-05-23 18:31    [W:0.030 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site