Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH] mmc: meson-gx: fix irq ack | Date | Thu, 23 May 2019 08:47:29 -0700 |
| |
Jerome Brunet <jbrunet@baylibre.com> writes:
> While cleaning the ISR of the meson-gx and acking only raised irqs, > the ack of the irq was moved at the very last stage of the function. > > This was stable during the initial tests but it triggered issues with > hs200, under specific loads (like booting android). Acking the irqs > after calling the mmc_request_done() causes the problem. > > Moving the ack back to the original place solves the issue. Since the > irq is edge triggered, it does not hurt to ack irq even earlier, so > let's do it early in the ISR. > > Fixes: 9c5fdb07a28d ("mmc: meson-gx: ack only raised irq") > Tested-by: Neil Armstrong <narmstrong@baylibre.com> > Tested-by: Kevin Hilman <khilman@baylibre.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
And to be clear, this fix should go into v5.2-rc.
My Tested-by is already above, but just for the benefit of the archives... tested this on mainline, and also on a v4.19 backport with Android and it fixes issues see there.
Kevin
| |