lkml.org 
[lkml]   [2019]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] net: ll_temac: Do not make promiscuous mode sticky on multicast
    Date
    When user has requested IFF_ALLMULTI or have set more than 4 multicast
    addresses, we should just use promiscuous mode, but not set it in flags,
    as it causes the interface to stay in promiscuous mode even when the
    non-IFF_PROMISC condition that caused promiscuous mode to be enabled
    has gone away.

    Signed-off-by: Esben Haabendal <esben@geanix.com>
    ---
    drivers/net/ethernet/xilinx/ll_temac_main.c | 7 -------
    1 file changed, 7 deletions(-)

    diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
    index 47c4515..05195ff 100644
    --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
    +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
    @@ -388,13 +388,6 @@ static void temac_set_multicast_list(struct net_device *ndev)
    mutex_lock(lp->indirect_mutex);
    if (ndev->flags & (IFF_ALLMULTI | IFF_PROMISC) ||
    netdev_mc_count(ndev) > MULTICAST_CAM_TABLE_NUM) {
    - /*
    - * We must make the kernel realise we had to move
    - * into promisc mode or we start all out war on
    - * the cable. If it was a promisc request the
    - * flag is already set. If not we assert it.
    - */
    - ndev->flags |= IFF_PROMISC;
    temac_indirect_out32(lp, XTE_AFM_OFFSET, XTE_AFM_EPPRM_MASK);
    dev_info(&ndev->dev, "Promiscuous mode enabled.\n");
    } else if (!netdev_mc_empty(ndev)) {
    --
    2.4.11
    \
     
     \ /
      Last update: 2019-05-23 14:03    [W:3.350 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site