Messages in this thread | | | Subject | Re: [PATCH net 2/4] net/udpgso_bench_tx: options to exercise TX CMSG | From | Fred Klassen <> | Date | Thu, 23 May 2019 19:10:05 -0700 |
| |
> > To ensure that we do not regress, when adding options, please consider > (just a general suggestion, not a strong request for this patch set) > updating the kselftest to run a variant of the test with the new code > coverage. In this case, make the code pass/fail instead of only user > interpretable and add variants to udpgso.sh.
I had a look at how kselftest works, and I absolutely want to see this work with these changes. I’ll investigate and implement in v2 patch.
I will most likely do a 5 second test. This seems to be sufficient to get meaningful results
> can use more precise CMSG_SPACE based on worst case expectations, like > in udp_sendmmsg > >> + char buf[1500]; > > no need for payload > >> +static void flush_errqueue(int fd) >> +{ >> + if (cfg_poll) { >> + struct pollfd fds = { 0 }; >> + int ret; >> + >> + fds.fd = fd; >> + fds.events = POLLERR; > > no need to pass POLLERR, it is always returned in revents.
| |