Messages in this thread | | | Subject | Re: [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is not set | From | Stephen Boyd <> | Date | Thu, 23 May 2019 15:46:03 -0700 |
| |
Quoting Fabiano Rosas (2019-05-23 12:53:11) > diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in > index 1d73083da6cb..2efbec6b6b8d 100644 > --- a/scripts/gdb/linux/constants.py.in > +++ b/scripts/gdb/linux/constants.py.in > @@ -40,7 +40,8 @@ > import gdb > > /* linux/clk-provider.h */ > -LX_GDBPARSED(CLK_GET_RATE_NOCACHE) > +if IS_BUILTIN(CONFIG_COMMON_CLK): > + LX_GDBPARSED(CLK_GET_RATE_NOCACHE) >
Why is this LX_GDBPARSED() instead of LX_VALUE()? From what I can tell it doesn't need to be runtime evaluated, just assigned to something that is macro expanded by CPP.
We should probably change the clk-provider.h header to export more things than what it's exporting right now when COMMON_CLK is disabled. I'm not sure why the whole thing is wrapped in a big ifdef.
Either way
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| |