Messages in this thread | | | Date | Thu, 23 May 2019 00:46:54 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] powerpc/powernv: fix variable "c" set but not used |
| |
On Thu, May 23, 2019 at 09:26:53AM +0200, Christophe Leroy wrote: > You are not fixing the problem, you are just hiding it. > > If the result of __get_user() is unneeded, it means __get_user() is not the > good function to use. > > Should use fault_in_pages_readable() instead.
Also it is not just the variable that is unused, but that whole function. I'll resend my series to remote it in a bit.
| |