Messages in this thread | | | Date | Wed, 22 May 2019 16:28:21 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] RDMA/mlx5: Use DIV_ROUND_UP_ULL macro to allow 32 bit to build |
| |
On Wed, May 22, 2019 at 02:54:50PM -0400, Steven Rostedt wrote: > > From: Steven Rostedt (VMware) <rostedt@goodmis.org> > > When testing 32 bit x86, my build failed with: > > ERROR: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined! > > It appears that a few non-ULL roundup() calls were made, which uses a > normal division against a 64 bit number. This is fine for x86_64, but > on 32 bit x86, it causes the compiler to look for a helper function > __udivdi3, which we do not have in the kernel, and thus fails to build. > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > ---
Do you like this version better?
https://patchwork.kernel.org/patch/10950913/
Jason
| |