Messages in this thread | | | Subject | Re: staging: Add rtl8723bs sdio wifi driver | From | Hans de Goede <> | Date | Tue, 21 May 2019 18:57:12 +0200 |
| |
Hi,
On 5/21/19 3:49 PM, Colin Ian King wrote: > Hi, > > static analysis with Coverity has detected an issues in the rtl8723bs > wifi driver: > > File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function > rtw_dbg_port(): > > CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) > dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true. > > if ((extra_arg & 0x07) > 0x07) > padapter->driver_ampdu_spacing = 0xFF; > else > padapter->driver_ampdu_spacing = extra_arg; > > > I'm not sure if the mask is (in)correct or the value it is being > compared to 0x07 is (in)correct (or both!)
Hmm, after looking at the rest of the code, it is clear that valid values for driver_ampdu_spacing or 0 - 7, otherwise it should be set to 0xff which means use the driver default.
I will send a patch fixing this.
Regards,
Hans
| |