Messages in this thread | | | Date | Tue, 21 May 2019 11:56:31 +0200 | From | Ondřej Jirman <> | Subject | Re: [PATCH v5 2/6] net: stmmac: sun8i: force select external PHY when no internal one |
| |
Hello Sergei,
On Tue, May 21, 2019 at 12:27:24PM +0300, Sergei Shtylyov wrote: > Hello! > > On 21.05.2019 2:50, megous@megous.com wrote: > > > From: Icenowy Zheng <icenowy@aosc.io> > > > > The PHY selection bit also exists on SoCs without an internal PHY; if it's > > set to 1 (internal PHY, default value) then the MAC will not make use of > > any PHY such SoCs. > ^ "on" or "with" missing?
It's missing 'on'.
thank you, Ondrej
> > This problem appears when adapting for H6, which has no real internal PHY > > (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 chip, > > connected via RMII interface at GPIO bank A). > > > > Force the PHY selection bit to 0 when the SOC doesn't have an internal PHY, > > to address the problem of a wrong default value. > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Signed-off-by: Ondrej Jirman <megous@megous.com> > [...] > > MBR, Sergei
| |