lkml.org 
[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 009/105] ARM: exynos: Fix a leaked reference by adding missing of_node_put
    Date
    From: Wen Yang <wen.yang99@zte.com.cn>

    commit 629266bf7229cd6a550075f5961f95607b823b59 upstream.

    The call to of_get_next_child returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with warnings like:
    arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put;
    acquired a node pointer with refcount incremented on line 193,
    but without a corresponding object release within this function.

    Cc: stable@vger.kernel.org
    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/mach-exynos/firmware.c | 1 +
    arch/arm/mach-exynos/suspend.c | 2 ++
    2 files changed, 3 insertions(+)

    --- a/arch/arm/mach-exynos/firmware.c
    +++ b/arch/arm/mach-exynos/firmware.c
    @@ -196,6 +196,7 @@ void __init exynos_firmware_init(void)
    return;

    addr = of_get_address(nd, 0, NULL, NULL);
    + of_node_put(nd);
    if (!addr) {
    pr_err("%s: No address specified.\n", __func__);
    return;
    --- a/arch/arm/mach-exynos/suspend.c
    +++ b/arch/arm/mach-exynos/suspend.c
    @@ -639,8 +639,10 @@ void __init exynos_pm_init(void)

    if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) {
    pr_warn("Outdated DT detected, suspend/resume will NOT work\n");
    + of_node_put(np);
    return;
    }
    + of_node_put(np);

    pm_data = (const struct exynos_pm_data *) match->data;


    \
     
     \ /
      Last update: 2019-05-20 14:49    [W:4.384 / U:2.960 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site