lkml.org 
[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/22] perf auxtrace: Fix itrace defaults for perf script
    Date
    Commit 4eb068157121 ("perf script: Make itrace script default to all
    calls") does not work for the case when '--itrace' only is used, because
    default_no_sample is not being passed.

    Example:

    Before:

    $ perf record -e intel_pt/cyc/u ls
    $ perf script --itrace > cmp1.txt
    $ perf script --itrace=cepwx > cmp2.txt
    $ diff -sq cmp1.txt cmp2.txt
    Files cmp1.txt and cmp2.txt differ

    After:

    $ perf script --itrace > cmp1.txt
    $ perf script --itrace=cepwx > cmp2.txt
    $ diff -sq cmp1.txt cmp2.txt
    Files cmp1.txt and cmp2.txt are identical

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Fixes: 4eb068157121 ("perf script: Make itrace script default to all calls")
    Cc: stable@vger.kernel.org
    ---
    tools/perf/util/auxtrace.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
    index fb76b6b232d4..5dd9d1893b89 100644
    --- a/tools/perf/util/auxtrace.c
    +++ b/tools/perf/util/auxtrace.c
    @@ -1010,7 +1010,8 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str,
    }

    if (!str) {
    - itrace_synth_opts__set_default(synth_opts, false);
    + itrace_synth_opts__set_default(synth_opts,
    + synth_opts->default_no_sample);
    return 0;
    }

    --
    2.17.1
    \
     
     \ /
      Last update: 2019-05-20 13:39    [W:4.218 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site