lkml.org 
[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Intel-gfx] [PATCH 18/33] fbdev: make unregister/unlink functions not fail
    Hi Daniel,

    I love your patch! Yet something to improve:

    [auto build test ERROR on linus/master]
    [also build test ERROR on v5.2-rc1 next-20190520]
    [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

    url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-notifier-begone/20190521-021841
    config: x86_64-randconfig-x003-201920 (attached as .config)
    compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
    reproduce:
    # save the attached .config to linux build tree
    make ARCH=x86_64

    If you fix the issue, kindly add following tag
    Reported-by: kbuild test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    drivers/video/fbdev/savage/savagefb_driver.c: In function 'savagefb_remove':
    >> drivers/video/fbdev/savage/savagefb_driver.c:2341:7: error: void value not ignored as it ought to be
    if (unregister_framebuffer(info))
    ^~~~~~~~~~~~~~~~~~~~~~

    vim +2341 drivers/video/fbdev/savage/savagefb_driver.c

    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2328
    48c68c4f drivers/video/savage/savagefb_driver.c Greg Kroah-Hartman 2012-12-21 2329 static void savagefb_remove(struct pci_dev *dev)
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2330 {
    b8901b09 drivers/video/savage/savagefb_driver.c Antonino A. Daplas 2006-01-09 2331 struct fb_info *info = pci_get_drvdata(dev);
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2332
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2333 DBG("savagefb_remove");
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2334
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2335 if (info) {
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2336 /*
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2337 * If unregister_framebuffer fails, then
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2338 * we will be leaving hooks that could cause
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2339 * oopsen laying around.
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2340 */
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 @2341 if (unregister_framebuffer(info))
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2342 printk(KERN_WARNING "savagefb: danger danger! "
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2343 "Oopsen imminent!\n");
    ^1da177e drivers/video/savage/savagefb_driver.c Linus Torvalds 2005-04-16 2344

    :::::: The code at line 2341 was first introduced by commit
    :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

    :::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
    :::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

    ---
    0-DAY kernel test infrastructure Open Source Technology Center
    https://lists.01.org/pipermail/kbuild-all Intel Corporation
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2019-05-20 21:26    [W:3.687 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site