[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354

On Mon, May 20, 2019 at 1:09 AM Arend Van Spriel
<> wrote:
> On 5/18/2019 12:54 AM, Douglas Anderson wrote:
> > In commit 29f6589140a1 ("brcmfmac: disable command decode in
> > sdio_aos") we disabled something called "command decode in sdio_aos"
> > for a whole bunch of Broadcom SDIO WiFi parts.
> >
> > After that patch landed I find that my kernel log on
> > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with:
> > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110
> >
> > This seems to happen every time the Broadcom WiFi transitions out of
> > sleep mode. Reverting the part of the commit that affects the WiFi on
> > my boards fixes the problem for me, so that's what this patch does.
> This sounds very similar to the issue we had during integration of wifi
> on rk3288 chromebooks years ago.

I'm working on those same Chromebooks. ;-) I'm working on trying to
make them well on newer kernels.

...but I guess you're saying that the problem faced by the people who
wanted commit 29f6589140a1 ("brcmfmac: disable command decode in
sdio_aos") are similar to the problems we saw in the past on those
Chromebooks. I'd tend to agree. In general it's difficult to get a
SD Host Controller to be fully robust in the fact of any/all errors on
the bus. While dw_mmc is pretty robust these days I'm assuming that
some other host controllers aren't.

> > Note that, in general, the justification in the original commit seemed
> > a little weak. It looked like someone was testing on a SD card
> > controller that would sometimes die if there were CRC errors on the
> > bus. This used to happen back in early days of dw_mmc (the controller
> > on my boards), but we fixed it. Disabling a feature on all boards
> > just because one SD card controller is broken seems bad.
> > instead of just this patch possibly the right thing to do is to fully
> > revert the original commit.
> I am leaning towards a full revert, but let's wait for more background info.

I'd be fine with a full revert too. Presumably that will break
someone but maybe they need to come up with a better solution?


 \ /
  Last update: 2019-05-20 20:21    [W:0.118 / U:9.932 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site