[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 4/5] KVM: LAPIC: Delay trace advance expire delta
On Mon, May 20, 2019 at 02:38:44PM +0800, Wanpeng Li wrote:
> On Sat, 18 May 2019 at 03:44, Sean Christopherson
> <> wrote:
> > This needs to be guarded with lapic_in_kernel(vcpu). But, since this is
> > all in the same flow, a better approach would be to return the delta from
> > wait_lapic_expire(). That saves 8 bytes in struct kvm_timer and avoids
> > additional checks for tracing the delta.
> As you know, the function wait_lapic_expire() will be moved to vmx.c
> and svm.c, so this is not suitable any more.

Doh, I was too excited about my cleverness and completely forgot why you
were moving the tracepoint in the first place.

 \ /
  Last update: 2019-05-20 16:57    [W:0.073 / U:32.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site