lkml.org 
[lkml]   [2019]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3/3] net: ethernet: add ag71xx driver
From
Date


On 20.05.19 02:33, Andrew Lunn wrote:
> Hi Oleksij
>
>> +static int ag71xx_mdio_mii_read(struct mii_bus *bus, int addr, int reg)
>> +{
>> + struct ag71xx *ag = bus->priv;
>> + struct net_device *ndev = ag->ndev;
>> + int err;
>> + int ret;
>> +
>> + err = ag71xx_mdio_wait_busy(ag);
>> + if (err)
>> + return err;
>> +
>> + ag71xx_wr(ag, AG71XX_REG_MII_CMD, MII_CMD_WRITE);
>
> It looks like you have not removed this.

done.

>
>> + ag71xx_wr(ag, AG71XX_REG_MII_ADDR,
>> + ((addr & 0xff) << MII_ADDR_SHIFT) | (reg & 0xff));
>> + ag71xx_wr(ag, AG71XX_REG_MII_CMD, MII_CMD_READ);
>> +
>> + err = ag71xx_mdio_wait_busy(ag);
>> + if (err)
>> + return err;
>> +
>> + ret = ag71xx_rr(ag, AG71XX_REG_MII_STATUS);
>> + /*
>> + * ar9331 doc: bits 31:16 are reserved and must be must be written
>> + * with zero.
>> + */
>> + ret &= 0xffff;
>> + ag71xx_wr(ag, AG71XX_REG_MII_CMD, MII_CMD_WRITE);
>
> Or this.

this one is needed. MII_CMD_WRITE is a wrong name, it is actually disabling MII_CMD_READ mode.

>
>> +
>> + netif_dbg(ag, link, ndev, "mii_read: addr=%04x, reg=%04x, value=%04x\n",
>> + addr, reg, ret);
>> +
>> + return ret;
>> +}
>> +
>> +static int ag71xx_mdio_mii_write(struct mii_bus *bus, int addr, int reg,
>> + u16 val)
>> +{
>> + struct ag71xx *ag = bus->priv;
>> + struct net_device *ndev = ag->ndev;
>> +
>> + netif_dbg(ag, link, ndev, "mii_write: addr=%04x, reg=%04x, value=%04x\n",
>> + addr, reg, val);
>> +
>> + ag71xx_wr(ag, AG71XX_REG_MII_ADDR,
>> + ((addr & 0xff) << MII_ADDR_SHIFT) | (reg & 0xff));
>
> addr have the vale 0-31. So a mask of 0xff is a couple of bits too
> big.

done

>
>> + ag71xx_wr(ag, AG71XX_REG_MII_CTRL, val);
>> +
>> + return ag71xx_mdio_wait_busy(ag);
>> +}
>
>> +static void ag71xx_link_adjust(struct ag71xx *ag, bool update)
>> +{
>> + struct net_device *ndev = ag->ndev;
>> + struct phy_device *phydev = ndev->phydev;
>> + u32 cfg2;
>> + u32 ifctl;
>> + u32 fifo5;
>> +
>> + if (!phydev->link && update) {
>> + ag71xx_hw_stop(ag);
>> + netif_carrier_off(ag->ndev);
>
> phylib will take care of the carrier for you.

done

> Andrew

thx!

Kind regards,
Oleksij Rempel

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2019-05-20 09:06    [W:0.042 / U:2.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site