lkml.org 
[lkml]   [2019]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 56/72] scsi: qla4xxx: fix a potential NULL pointer dereference
    Date
    [ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ]

    In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL
    pointer dereference.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Acked-by: Manish Rangankar <mrangankar@marvell.com>
    Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/scsi/qla4xxx/ql4_os.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
    index 575445c761b4..5dd3e4e01b10 100644
    --- a/drivers/scsi/qla4xxx/ql4_os.c
    +++ b/drivers/scsi/qla4xxx/ql4_os.c
    @@ -3204,6 +3204,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session,
    if (iscsi_conn_bind(cls_session, cls_conn, is_leading))
    return -EINVAL;
    ep = iscsi_lookup_endpoint(transport_fd);
    + if (!ep)
    + return -EINVAL;
    conn = cls_conn->dd_data;
    qla_conn = conn->dd_data;
    qla_conn->qla_ep = ep->dd_data;
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-05-02 17:42    [W:2.129 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site